pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

refactor: add unit test on sponsor api #1140

Closed baby230211 closed 9 months ago

baby230211 commented 1 year ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

add unit test on sponsor list api add unit test on jobs list api

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Related Issue

If applicable, refernce to the issue related to this pull request.

More Information

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. You may also want to refer to how to wirte the perfect pull request

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.65 :tada:

Comparison is base (3be480d) 69.74% compared to head (77c8443) 70.39%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1140 +/- ## ========================================== + Coverage 69.74% 70.39% +0.65% ========================================== Files 85 85 Lines 3378 3378 ========================================== + Hits 2356 2378 +22 + Misses 1022 1000 -22 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1140/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mattwang44 commented 1 year ago

@josix please handle the conflict between this PR and #1133 when you're available, thx!

josix commented 9 months ago

Sorry @baby230211, It's my fault... I forgot the #1133 has covered these tests. I probably need to close this PR 😭