pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

[Feat] add category filter on review page #1145

Closed iknowright closed 6 months ago

iknowright commented 1 year ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

Describe what the change is Add category filed to proposal table. When you click on a category, the list of proposals will be filtered by the category you selected.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to review page
  2. Click on category filed

Expected behavior

Show the proposal list which was be filtered.

Related Issue

If applicable, refernce to the issue related to this pull request.

More Information

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. You may also want to refer to how to wirte the perfect pull request

https://user-images.githubusercontent.com/31035650/162525223-95f100f8-a7d8-4bef-a44b-37056f6d0a64.mov

codecov-commenter commented 1 year ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3be480d) 69.74% compared to head (daa9f1b) 70.59%. Report is 35 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1145 +/- ## ========================================== + Coverage 69.74% 70.59% +0.84% ========================================== Files 85 85 Lines 3378 3394 +16 ========================================== + Hits 2356 2396 +40 + Misses 1022 998 -24 ``` | [Files](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw) | Coverage Δ | | |---|---|---| | [src/reviews/views.py](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw#diff-c3JjL3Jldmlld3Mvdmlld3MucHk=) | `29.86% <15.38%> (-1.44%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1145/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iknowright commented 1 year ago

outcome

https://github.com/pycontw/pycon.tw/assets/25934612/1ac011c9-bf34-4983-beb7-802bdc0e5663

iknowright commented 10 months ago

@josix https://github.com/pycontw/pycon.tw/assets/25934612/9e519b89-c331-4d91-a33f-e2fd6e3b3384

updated outcome