search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

test(ccip): add test cases for ccip apis #1150

Closed erik1110 closed 9 months ago

erik1110 commented 10 months ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

Describe what the change is You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly self-describe enough about how you change the code.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Related Issue

If applicable, refernce to the issue related to this pull request.

More Information

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. You may also want to refer to how to wirte the perfect pull request

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (74b334a) 69.74% compared to head (a200f81) 70.80%. Report is 12 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1150 +/- ## ========================================== + Coverage 69.74% 70.80% +1.06% ========================================== Files 85 85 Lines 3378 3381 +3 ========================================== + Hits 2356 2394 +38 + Misses 1022 987 -35 ``` | [Files](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw) | Coverage Δ | | |---|---|---| | [src/sponsors/translation.py](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw#diff-c3JjL3Nwb25zb3JzL3RyYW5zbGF0aW9uLnB5) | `100.00% <100.00%> (ø)` | | | [src/ccip/views.py](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw#diff-c3JjL2NjaXAvdmlld3MucHk=) | `53.39% <50.00%> (+19.73%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/pycontw/pycon.tw/pull/1150/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pycontw)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

josix commented 10 months ago

hi @erik1110, per discussion, please add the related entities like customEvents, and proposals to the fixtures so that the tests could simulate the actual scenario.

erik1110 commented 9 months ago

hi @erik1110, per discussion, please add the related entities like customEvents, and proposals to the fixtures so that the tests could simulate the actual scenario.

OK, I will add another pull request!