pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

fix `/usr/local/app/node_modules/.bin/node-sass: not found` #1157

Closed iknowright closed 5 months ago

iknowright commented 5 months ago

fix node_modules path for production dockerfile

Types of changes

Description

Describe what the change is related to #1156 After #1151 , the node_modules are misplaced. Should be in usr/local/app.

Steps to Test This Pull Request

Re-build image using updated Dockerfile

Expected behavior

No longer need a manual fix for node_modules path

Related Issue

1156

More Information

Run and tested in staging vm

codecov-commenter commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (daa9f1b) 70.59% compared to head (913fef7) 70.59%. Report is 37 commits behind head on master.

Files Patch % Lines
src/ccip/views.py 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1157 +/- ## ======================================= Coverage 70.59% 70.59% ======================================= Files 85 85 Lines 3394 3394 ======================================= Hits 2396 2396 Misses 998 998 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.