pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
95 stars 107 forks source link

feat: update code-of-conduct 2024 version #1161

Closed rockleona closed 7 months ago

rockleona commented 7 months ago

Types of changes

Description

Update Code of Conduct to 2024 version

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Start dev server
  2. Enter http://localhost:8000/zh-hant/about/code-of-conduct/
  3. Also enter http://localhost:8000/en-us/about/code-of-conduct/

Expected behavior

A clear and concise description of what you expected to happen.

Related Issue

resolve #1159 resolve #1158

More Information

Screenshots

zh-hant ![image](https://github.com/pycontw/pycon.tw/assets/34214497/6d20ef37-9822-4813-98ea-5c7205298f69)
en-us ![image](https://github.com/pycontw/pycon.tw/assets/34214497/ef1b19ac-290d-416c-a53d-1747ac33a276)
codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (913fef7) 70.59% compared to head (267c525) 70.59%. Report is 9 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1161 +/- ## ======================================= Coverage 70.59% 70.59% ======================================= Files 85 85 Lines 3394 3394 ======================================= Hits 2396 2396 Misses 998 998 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rockleona commented 7 months ago

@SivanYeh, I'm curious about the routes,

Since I entered http://localhost:8000/zh-hant/about/code-of-conduct/, then it rendered the previous template ( maybe it's PyCon TW 2021 ?).

You can checkout the screenshots I've wrote in the description.

SivanYeh commented 7 months ago

@SivanYeh, I'm curious about the routes,

Since I entered http://localhost:8000/zh-hant/about/code-of-conduct/, then it rendered the previous template ( maybe it's PyCon TW 2021 ?).

You can checkout the screenshots I've wrote in the description.

Hm, this is not a bug I can figure out fast atm @mattwang44 we need a hand!

mattwang44 commented 7 months ago

應該是想改動這個功能沒錯吧? 是的話這個功能是會在每個 user 當年度首次投稿(或者 CoC 版本有更動後嘗試投稿或編輯稿件)時跳出 CoC 同意頁面,所以測試方式應該是走一遍投稿流程,而不是去 access 舊版且該被刪除的 CoC 前端頁面(但他們共用 template)

rockleona commented 7 months ago

應該是想改動這個功能沒錯吧? 是的話這個功能是會在每個 user 當年度首次投稿(或者 CoC 版本有更動後嘗試投稿或編輯稿件)時跳出 CoC 同意頁面,所以測試方式應該是走一遍投稿流程,而不是去 access 舊版且該被刪除的 CoC 前端頁面(但他們共用 template)

原來如此,我沒看過這個文件不知道! 那我來看一下怎麼測試投稿,因為現在看起來我在 dev 沒有這些按鈕可以按@@

mattwang44 commented 7 months ago

應該是想改動這個功能沒錯吧? 是的話這個功能是會在每個 user 當年度首次投稿(或者 CoC 版本有更動後嘗試投稿或編輯稿件)時跳出 CoC 同意頁面,所以測試方式應該是走一遍投稿流程,而不是去 access 舊版且該被刪除的 CoC 前端頁面(但他們共用 template)

原來如此,我沒看過這個文件不知道! 那我來看一下怎麼測試投稿,因為現在看起來我在 dev 沒有這些按鈕可以按@@

可參考切換投稿階段的 readme,必須先切換到允許上傳投稿的階段才會有這些按紐

rockleona commented 7 months ago

應該是想改動這個功能沒錯吧? 是的話這個功能是會在每個 user 當年度首次投稿(或者 CoC 版本有更動後嘗試投稿或編輯稿件)時跳出 CoC 同意頁面,所以測試方式應該是走一遍投稿流程,而不是去 access 舊版且該被刪除的 CoC 前端頁面(但他們共用 template)

原來如此,我沒看過這個文件不知道! 那我來看一下怎麼測試投稿,因為現在看起來我在 dev 沒有這些按鈕可以按@@

可參考切換投稿階段的 readme,必須先切換到允許上傳投稿的階段才會有這些按紐

我認為已經喬到 CFP stage 的參數設定了,但還是沒出現@@

image

image

mattwang44 commented 7 months ago

@rockleona SLUG 要替換成 pycontw-2024 可以再讀一下 readme 的敘述

rockleona commented 7 months ago

@rockleona SLUG 要替換成 pycontw-2024

糟糕沒看清楚....感謝 !

rockleona commented 7 months ago

@SivanYeh 截圖更新了,再麻煩幫我 Review !