search

pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

remove prefer_time for cfp #1166

Closed SivanYeh closed 4 months ago

SivanYeh commented 4 months ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

Describe what the change is Remove options for cfp -"prefer_time" from src/core/choices.py and src/core/models.py then executed the following: $ python manage.py makemigrations $ python manage.py makemessages -l en_US -l zh_Hant

In addition, "prefer_time" in testing files:

  1. src/proposals/tests/views/test_create.py
  2. src/proposals/tests/views/test_proposal.py have to remove also.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to 'http://localhost:8000/admin/'
  2. LogIn Information
  3. Click on 專業課程提案
  4. Check if option "偏好議程時間" is removed
  5. Repeated step 3-4 for 演講提案

Expected behavior

"偏好議程時間" is removed on each page in Zh/En.

Related Issue

If applicable, refernce to the issue related to this pull request.

1163

Additional context Screenshot:

image
codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.57%. Comparing base (5203935) to head (dfabd13). Report is 11 commits behind head on master.

:exclamation: Current head dfabd13 differs from pull request most recent head 7726ba7. Consider uploading reports for the commit 7726ba7 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1166 +/- ## ========================================== - Coverage 70.59% 70.57% -0.02% ========================================== Files 85 85 Lines 3394 3392 -2 ========================================== - Hits 2396 2394 -2 Misses 998 998 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.