Open SivanYeh opened 2 months ago
@mattwang44 uncertain if it's a good solution: When I simply remove if/else statement in the dispatch function, 404 no longer shows up(of course) while speaker A remains unaffected(Did I miss anything?)
記得修改 test cases
記得修改 test cases
賀! 研究中
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.99%. Comparing base (
fca6fd2
) to head (a018685
). Report is 46 commits behind head on master.:exclamation: Current head a018685 differs from pull request most recent head 6a6c2d5
Please upload reports for the commit 6a6c2d5 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mattwang44 I thought “request” can be one of parameters to switch the edit status and check if additional speaker is allowed to update/cancel the form during uneditable time.
...seems like “request” is not included in these two forms. (Based on the par “request” came from “RequestUserValidationMixin”, which is not indcluded in “AdditionalSpeakerUpdateForm”.)
What is the key par should I consider?
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an
x
in the box that appliesDescription
Resolve 404 error and strange style of table after co-speaker pressed accept/decline during reviewing stage, which "SLUG.proposals.editable" is false.
Steps to Test This Pull Request
Steps to reproduce the behavior:
Expected behavior
404 happened in Step[7] disappear.
More Information
Screenshots