fix(category): fix category filtering not working when order by other…

[iknowright]

fix category filtering not working when ordered by other attributes on review table

Types of changes

• [x] Bugfix
• [ ] New feature
• [ ] Refactoring
• [ ] Breaking change (any change that would cause existing functionality to not work as expected)
• [ ] Documentation Update
• [ ] Other (please describe)

Description

based on

• https://github.com/pycontw/pycon.tw/blob/daa9f1bfcba8ff46b949f461027138e7a37e664d/src/reviews/views.py#L58
• https://github.com/pycontw/pycon.tw/commit/daa9f1bfcba8ff46b949f461027138e7a37e664d#diff-5bdfe306a76d6b002ae0142965af34400c9baacae4ad6329a82304a1ac15bf4c
• message https://discord.com/channels/752904426057892052/1198661987761131682/1229294973846032406 Andy found category filtering not working when 1. category is ALL and 2. apply a sort on other attributes This happens because Django template with generate None string to a None value which caused backend unable to filter the entries properly.

Steps to Test This Pull Request

Steps to reproduce the behavior:

1. Go to review page
2. when default ALL is applied
3. click any sort button on any column
4. will show none of proposals (expected all)m.

Solution

applied |default'' template tag to sorting <a href> tag to make category appears to be empty on URL location, then backend will not filter it wrong.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.19%. Comparing base (fca6fd2) to head (53b0638). Report is 5 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1193 +/- ## ======================================= Coverage 71.19% 71.19% ======================================= Files 84 84 Lines 3451 3451 ======================================= Hits 2457 2457 Misses 994 994 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[SivanYeh]

LGTM!