Closed mhsiungw closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.99%. Comparing base (
53b0638
) to head (0fa2454
). Report is 31 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM @SivanYeh would you please try to deploy this branch on staging and check if everything works fine 🙏🏽
Count on me! I will do this tomorrow and tell you guys how it goes
LGTM @SivanYeh would you please try to deploy this branch on staging and check if everything works fine 🙏🏽
Count on me! I will do this tomorrow and tell you guys how it goes
It works well! No error were found during docker build, and websites on staging are functioning. I attach docker logs here:docker_20240510.log
If no further issues are found, and staging remains stable throughout the weekend, I will merge to main branch and deploy to prod.
@SivanYeh I believe we can merge this, right?
@SivanYeh I believe we can merge this, right?
Yes! Sorry for the delay. I was quite busy yesterday
Types of changes
Description
Merge both dev and prod Dockerfile into one and divide it into multi stages.
Steps to Test This Pull Request
Test dev stage
delete related containers and images
run the following command
start server
Test prod stage
create
docker-compose-prod-demo.yml
filenetworks: network-2024: name: network-2024
More Information
ENV PATH /usr/local/bin:$PATH
due to duplicate entries/usr/local/bin
ENV PATH /home/docker/.local/bin:$PATH
to centralise where pip install packages and to align the PATH between production environment and development environment.chown -R docker:nogroup "$BASE_DIR" "$APP_DIR"
and useCOPY --chown
instead to avoid unnecessary image size increasing. references: https://garbers.co.za/2017/11/15/reduce-docker-image-size-chmod-chown/ , https://stackoverflow.com/questions/30085621/why-does-chown-increase-size-of-docker-image