pycontw / pycon.tw

PyCon TW Proposal System & Backend Server
https://tw.pycon.org/prs
MIT License
94 stars 107 forks source link

feat: control displayed sponsors #1199

Closed Ritabear closed 1 week ago

Ritabear commented 3 weeks ago

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

Description

Describe what the change is You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly self-describe enough about how you change the code.

issue related: #508

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.01%. Comparing base (0fa2454) to head (2a232a0). Report is 11 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1199 +/- ## ========================================== + Coverage 73.99% 74.01% +0.02% ========================================== Files 81 81 Lines 3057 3060 +3 ========================================== + Hits 2262 2265 +3 Misses 795 795 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SivanYeh commented 1 week ago

I tested it on staging and found previous logos would disappear.

Pasted Graphic 1

Is it normal? Should we inform sponsor team to recreate logos for new control?