pycontw / pycon_archive_past_website

Freeze and archive historical PyConTW official websites as static sites.
MIT License
4 stars 7 forks source link

Failed to fetch favicon and images in background-image #15

Closed josix closed 3 years ago

josix commented 3 years ago

Describe the bug Currently the deployed static gh-page has different base url from original official websites, it will cause the site got 404 for pages and images. We need to change the relative path of image/link in each scraped page.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://pycontw.github.io/pycon_archive_past_website/2020/zh-hant/ (same as 2016-2019)
  2. See the errors that showed in console like image below image

Expected behavior Successfully access all background image with customized base_url in its path

josix commented 3 years ago

Resovled by #17