pycontw / pycontw-frontend

The official website for PyCon TW 🐍
16 stars 36 forks source link

chore(env): adjust scripts for json-server #538

Closed wanyewei closed 3 months ago

wanyewei commented 3 months ago

Types of changes

Description

解決在windows環境下,run json-server 出現的錯誤 image

Steps to Test This Pull Request

  1. 在vscode的terminal執行npm run json-server
  2. 在vscode的terminal內會顯示 Home http://localhost:9876
  3. 到瀏覽器上輸入 http://localhost:9876,成功跑出畫面

Expected behavior

image

Additional context

netlify[bot] commented 3 months ago

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
Latest commit c36c9cc6b0f96e1d23ff6c88b4ec231dc8f08b65
Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/6669ba9b8920780007dff724
Deploy Preview https://deploy-preview-538--zesty-gnome-f04144.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
Latest commit c36c9cc6b0f96e1d23ff6c88b4ec231dc8f08b65
Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/6669ba9b8ec5f10008c084f3
Deploy Preview https://deploy-preview-538--classy-granita-bc2b5a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SivanYeh commented 3 months ago

剛剛測試這些改動在我的本地端也是相容的(MacOS M1)->除了package-lock.json 我有疑問, 其餘我覺得可以併到codebase了. @mattwang44 @josix @baby230211 可以協助看看 .eslintrc.js與package.json上的變更是安全的嗎?

mattwang44 commented 3 months ago

yes, these changes look safe to me

tyuchx commented 3 months ago

LGTM

After nvm use 16.20.2 && npm ci, both npm run json-server and npm run lint work fine on my machine (M3 Sonoma 14.4).