pycontw / pycontw-frontend

The official website for PyCon TW 🐍
16 stars 36 forks source link

feat(speech): toggle talks and tutorials pages #550

Closed SivanYeh closed 3 months ago

SivanYeh commented 4 months ago

Types of changes

Description

Switch on 2024 Tutorials(專業課程) and Talks(一般演講) pages

Steps to Test This Pull Request

  1. Go to path/2024/zh-hant/conference/talks
  2. Go to path/2024/zh-hant/conference/tutorials
  3. Check if they can be entered from navigation bar "Conference/Talks" and "Conference/Tutorials"

Expected behavior

image

Related Issue

529

528

netlify[bot] commented 4 months ago

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
Latest commit e5b04a8f13a42c73195c17705eddb145cb45948f
Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66933a9c8911620008f5ab60
Deploy Preview https://deploy-preview-550--classy-granita-bc2b5a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
Latest commit e5b04a8f13a42c73195c17705eddb145cb45948f
Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66933a9c45add0000959682a
Deploy Preview https://deploy-preview-550--zesty-gnome-f04144.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SivanYeh commented 4 months ago

@mattwang44 @josix 本地端點擊任一演講區塊出現錯誤。我漏開了什麼嗎? 點擊: image

出現錯誤: image

GET /speeches/?event_type=talk,sponsored 304 9.700 ms - - GET /speeches/?event_type=talk&id=3&singular=1 304 4.415 ms - - GET /speeches/?event_type=category&id=SEC&singular=1 404 3.363 ms - 2

mattwang44 commented 4 months ago

有跑 npm run json-server 嗎? 這個頁面上的資料是透過 API 拿到的(local dev 現在應該還是?)

SivanYeh commented 4 months ago

有跑npm run json-server~ local dev有輸入兩筆假資料. 不過按照顯示結果應該是直接去API抓

mattwang44 commented 4 months ago

@SivanYeh please test it out with this patch https://github.com/pycontw/pycontw-frontend/pull/551

SivanYeh commented 3 months ago

@tomatoprinx The previous is fixed by Matt. Please check again on your local~