Segmentation fault when trying to open Digital TV

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
Click on File -> TV -> Open Digital TV

What is the expected output? What do you see instead?
I would expect to see a TV channel or a channel list. Instead gnome-mplayer 
immediately crashes. DVB-T is working on this PC (MPlayer, Kaffeine).

What version of the product are you using? On what operating system?
gnome-mplayer SVN on Debian 5.0 "Lenny" (stable) with kernel 2.6.26

Please provide any additional information below.
GDB debug output:
[...]
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb6a62700 (LWP 3250)]
0xb6db227d in fclose () from /lib/i686/cmov/libc.so.6
(gdb) bt
#0  0xb6db227d in fclose () from /lib/i686/cmov/libc.so.6
#1  0x080660f6 in menuitem_open_dtv_callback (menuitem=0x8a54ce0, data=0x0) at 
gui.c:3330
#2  0xb7162064 in g_cclosure_marshal_VOID__VOID () from 
/usr/lib/libgobject-2.0.so.0
#3  0xb715490b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#4  0xb7167e6d in ?? () from /usr/lib/libgobject-2.0.so.0
#5  0x08a751e0 in ?? ()
#6  0x00000000 in ?? ()

Original issue reported on code.google.com by cbr...@gmx.net on 1 Dec 2010 at 10:20

GoogleCodeExporter commented 8 years ago

Can you please post your channels.conf file. So I can use it for testing?

Original comment by kdeko...@gmail.com on 2 Dec 2010 at 1:04

GoogleCodeExporter commented 8 years ago

[4013]:198500000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMISS
ION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:0:0:16403
[400a]:198500000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMISS
ION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:0:0:16394
[400e]:198500000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMISS
ION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:0:0:16398
[4018]:198500000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMISS
ION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:0:0:16408
PHOENIX:198500000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMIS
SION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:0:0:3
Bayerisches 
FS:198500000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMISSION_
MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:0:0:33
SWR Fernsehen 
RP:198500000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMISSION_
MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:0:0:226
ZDF:482000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSION
_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:545:546:514
3sat:482000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSIO
N_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:561:562:515
neo/KiKa:482000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMI
SSION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:593:594:517
ZDFinfokanal:482000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRA
NSMISSION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:577:578:516
RTL 
Hessen:578000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISS
ION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:337:338:16405
RTL2:578000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSIO
N_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:353:354:16406
SuperRTL:578000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMI
SSION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:433:434:16411
VOX:578000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSION
_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:545:546:16418
Das 
Erste:602000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRANSMISSI
ON_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:101:102:1
hr-fernsehen:602000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_2_3:QAM_16:TRA
NSMISSION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:401:402:65
arte/EinsExtra:602000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_2_3:QAM_16:T
RANSMISSION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:201:202:70
TELE 
5:722000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSION_M
ODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:465:466:16413
Bibel 
TV:722000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSION_
MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:673:674:16426
QVC:722000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSION
_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:577:578:16420
Channel 
21/rheinmaintv:722000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:T
RANSMISSION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:2817:2818:19200
ProSieben:738000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSM
ISSION_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:305:306:16403
kabel 
eins:738000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSIO
N_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:161:162:16394
N24:738000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSION
_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:225:226:16398
SAT.1:738000000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_1_2:QAM_16:TRANSMISSI
ON_MODE_8K:GUARD_INTERVAL_1_4:HIERARCHY_NONE:385:386:16408

Original comment by cbr...@gmx.net on 2 Dec 2010 at 8:27

GoogleCodeExporter commented 8 years ago

Hum.... doesn't crash here with SVN r1791.. haven't made any changes to that 
code however.

Original comment by kdeko...@gmail.com on 2 Dec 2010 at 8:54

GoogleCodeExporter commented 8 years ago

gnome-mplayer 1.0.2~svn1919 from the motumedia daily PPA crashes on my Ubuntu 
Maverick as well.

'mplayer dvb://' works fine.

Original comment by jsilt...@gmail.com on 4 Apr 2011 at 1:53

GoogleCodeExporter commented 8 years ago

Can you please provide a backtrace? I don't have the equipment to test this and 
it doesn't crash on my setup.

However, can you try svn r1976?

Original comment by kdeko...@gmail.com on 4 Apr 2011 at 2:24

GoogleCodeExporter commented 8 years ago

Can you please retest svn r2088?

Original comment by kdeko...@gmail.com on 10 May 2011 at 10:13

GoogleCodeExporter commented 8 years ago

I have found that the channels.conf file needs to be in UTF-8 encoding. So if 
you are having crashes you may want to open the file in gedit and ensure that 
the encoding is set to utf8

Original comment by kdeko...@gmail.com on 27 Sep 2011 at 4:20

GoogleCodeExporter commented 8 years ago

Same problem here on Fedora 17 and the latest version of gnome-mplayer
For me it seems the problem comes from the function "parseChannels" in gui.c 
the string s is defined as having 20 characters, but in the loop the index i 
gets bigger (35, 36 ...).
The attached channels.conf allow to see that.

Original comment by anthonyd...@gmail.com on 3 Oct 2012 at 8:14

Attachments:

channels.conf

GoogleCodeExporter commented 8 years ago

With the SVN code (1.0.7a1) this channels.conf does not cause gnome-mplayer to 
crash. Can you provide a backtrace so that I can confirm the problem.

Original comment by kdeko...@gmail.com on 3 Oct 2012 at 8:29

GoogleCodeExporter commented 8 years ago

#0  0x00007ffff6144925 in raise () from /lib64/libc.so.6
#1  0x00007ffff61460d8 in abort () from /lib64/libc.so.6
#2  0x00007ffff6183e6b in __libc_message () from /lib64/libc.so.6
#3  0x00007ffff62184c7 in __fortify_fail () from /lib64/libc.so.6
#4  0x00007ffff6218490 in __stack_chk_fail () from /lib64/libc.so.6
#5  0x000000000041d625 in parseChannels (f=f@entry=0xda1600) at gui.c:3094
#6  0x000000000041d6ca in menuitem_open_dtv_callback (
    menuitem=<optimized out>, data=<optimized out>) at gui.c:3110
#7  0x00007ffff7557664 in g_closure_invoke () from /lib64/libgobject-2.0.so.0
#8  0x00007ffff75686d8 in ?? () from /lib64/libgobject-2.0.so.0
#9  0x00007ffff757066d in g_signal_emit_valist ()
   from /lib64/libgobject-2.0.so.0
#10 0x00007ffff75707c2 in g_signal_emit () from /lib64/libgobject-2.0.so.0
#11 0x0000003398ca251c in gtk_widget_activate () from /lib64/libgtk-3.so.0
#12 0x0000003398b95c3e in gtk_menu_shell_activate_item ()
   from /lib64/libgtk-3.so.0
#13 0x0000003398b95fcb in ?? () from /lib64/libgtk-3.so.0
#14 0x0000003398b7afdf in ?? () from /lib64/libgtk-3.so.0
#15 0x00007ffff7557943 in ?? () from /lib64/libgobject-2.0.so.0
#16 0x00007ffff756fd88 in g_signal_emit_valist ()
   from /lib64/libgobject-2.0.so.0
#17 0x00007ffff75707c2 in g_signal_emit () from /lib64/libgobject-2.0.so.0
#18 0x0000003398ca311e in ?? () from /lib64/libgtk-3.so.0
---Type <return> to continue, or q <return> to quit--- 
#19 0x0000003398b78fa6 in ?? () from /lib64/libgtk-3.so.0
#20 0x0000003398b7abb3 in gtk_main_do_event () from /lib64/libgtk-3.so.0
#21 0x0000003397248e82 in ?? () from /lib64/libgdk-3.so.0
#22 0x00007ffff6e65825 in g_main_context_dispatch ()
   from /lib64/libglib-2.0.so.0
#23 0x00007ffff6e65b58 in ?? () from /lib64/libglib-2.0.so.0
#24 0x00007ffff6e65f52 in g_main_loop_run () from /lib64/libglib-2.0.so.0
#25 0x0000003398b79f75 in gtk_main () from /lib64/libgtk-3.so.0
#26 0x000000000040f842 in main (argc=1, argv=0x7fffffffe108) at main.c:1331
(gdb)

Original comment by anthonyd...@gmail.com on 3 Oct 2012 at 9:06

GoogleCodeExporter commented 8 years ago

What version of gnome-mplayer is that from?

Original comment by kdeko...@gmail.com on 4 Oct 2012 at 2:49

GoogleCodeExporter commented 8 years ago

It is the 1.0.6 which comes with Fedora 17.
Looking at the code of the latest svn version. It should still occur.

Original comment by anthonyd...@gmail.com on 4 Oct 2012 at 8:23

GoogleCodeExporter commented 8 years ago

Ok, I increased the buffer from 20 to 256, and put in a buffer overflow check. 
I really need to rewrite this submitted code to use dynamic allocation and that 
should fix the issue correctly.

Original comment by kdeko...@gmail.com on 4 Oct 2012 at 12:43

Changed state: Started

GoogleCodeExporter commented 8 years ago

You are right. I think the function g_strsplit would be great for that.

Original comment by anthonyd...@gmail.com on 4 Oct 2012 at 3:41

pycousin / gnome-mplayer

Segmentation fault when trying to open Digital TV #462