pycousin / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
0 stars 0 forks source link

build issues due to gm_log #625

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

2282 and 2284 at the least result in build failures. This is what happens with 
2282:

nautilus_property_page.c: In function 'get_metadata':
nautilus_property_page.c:138:16: error: 'verbose' undeclared (first use in this 
function)
nautilus_property_page.c:138:16: note: each undeclared identifier is reported 
only once for each function it appears in
make[4]: *** [libgnome_mplayer_properties_page_so-nautilus_property_page.o] 
Error 1

and 2284:

dbus-interface.o: In function `switch_screensaver_xdg_screensaver':
/build/buildd/gnome-mplayer-1.0.7a1~svn2288/src/dbus-interface.c:1521: 
undefined reference to `WEXITSTATUS'
/build/buildd/gnome-mplayer-1.0.7a1~svn2288/src/dbus-interface.c:1522: 
undefined reference to `WIFSIGNALED'
/build/buildd/gnome-mplayer-1.0.7a1~svn2288/src/dbus-interface.c:1523: 
undefined reference to `WTERMSIG'

It seems like this stuff isn't being defined in the gm_log header so the build 
system has no idea what the code is talking about. There may be other build 
failures once these are fixed. Kevin defined 'verbose' in 
nautilus_property_page.c in 2288, but that strikes me as a temporary fix.

Original issue reported on code.google.com by brandonj...@gmail.com on 23 Jun 2012 at 3:36

GoogleCodeExporter commented 8 years ago
The fix to nautilus_property_page.c is correct as that file is turned into a 
plugin and I didn't want to drag any unnecessary files/definitions in.

The problems with dbus-interface.o should be fixed now as well. Those macros 
didn't break the build on Fedora, but due to the flags Ubuntu uses, the errors 
show up.

Original comment by kdeko...@gmail.com on 23 Jun 2012 at 5:40

GoogleCodeExporter commented 8 years ago
Thanks Kevin

Original comment by brandonj...@gmail.com on 23 Jun 2012 at 6:24