search

pycousin / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
0 stars 0 forks source link

should fallback to non-symbolic icons if no icon theme with symbolic icons is available #656

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Since 1.0.7 gnome-mplayer uses symbolic icons. If the icon theme doesn't have 
symbolic icons, the user is left with a standard icon everywhere and can't 
distinguish the buttons easily. I suggest to fallback to the non-symbolic 
version of the icon if the symbolic icon is not available.

Original issue reported on code.google.com by s.ramac...@gmail.com on 17 Nov 2012 at 6:11

GoogleCodeExporter commented 8 years ago 
What about the attached patch? It's based on the patch at [1].

[1] http://bugzilla-attachments.gnome.org/attachment.cgi?id=156890

Original comment by s.ramac...@gmail.com on 17 Nov 2012 at 8:17

Attachments:

GoogleCodeExporter commented 8 years ago 
Do you have a theme I can test with? The one I use happens to have symbolic 
icons and so I don't see the problem.

Original comment by kdeko...@gmail.com on 18 Nov 2012 at 4:43

GoogleCodeExporter commented 8 years ago 
The HighContrast theme (in Debian shipped in gnome-themes-standard) comes 
without symbolic icons. Other example include LowContrast and oxygen.

Original comment by s.ramac...@gmail.com on 18 Nov 2012 at 5:22

GoogleCodeExporter commented 8 years ago 
Should be fixed in SVN r2357, very simple patch.

Original comment by kdeko...@gmail.com on 19 Nov 2012 at 2:13

GoogleCodeExporter commented 8 years ago 
There are still some -symbolic icons used unconditionally in lines 1196, 1222, 
1247, 2597, 2611, 2718, 2768, 6797, 6833, 6878, 8439 and 8473.

Original comment by s.ramac...@gmail.com on 24 Nov 2012 at 7:11

GoogleCodeExporter commented 8 years ago 
-symbolic icons have been wrapped. Providing a patch would have been helpful in 
this case. Also the lack of symbolic icons in an icon theme is actually a bug 
in the theme. Suggest you pursue bugs in those packages as well.

Original comment by kdeko...@gmail.com on 25 Nov 2012 at 2:11

GoogleCodeExporter commented 8 years ago 
Well, my initial patch covered all -symbolics.

Original comment by s.ramac...@gmail.com on 25 Nov 2012 at 2:21

GoogleCodeExporter commented 8 years ago 
Appears I missed the patch and only saw the link to the notify fix. (probably 
because I read it on my phone).

Original comment by kdeko...@gmail.com on 25 Nov 2012 at 2:24