Closed maddenj-ie closed 2 months ago
It seems the json parsing does not take the UEOSId
part into account. This is because this IE is optional, and the general behaviour when setting values for such NAS messages is:
set_trans(False)
.Currently, the JSON parsing routing follows the same principle. But maybe, as it seems common to use JSON to set entire PDU values all IEs at once (incl. optional ones, and including after class initialization), this could follow a behaviour similar to the binary parser otherwise. I'll check this further later. Thanks for reporting
Commit https://github.com/pycrate-org/pycrate/commit/97d4d7d0b37653d7b45c88ce934799fe42fced98 should solve this issue. Can you give a try with the last tagged release?
@mitshell Thanks the fix and the tag. I'll test as soon as a I can.
@mitshell the unit test above fails as before. Perhaps, i'm not using it correctly. If this is the case, can you please provide an example, thanks.
This should now be fixed with: https://github.com/pycrate-org/pycrate/commit/1520fec7a427ae430138af59149b7de00d175bdc. If you confirm, I can re-tag a minor release.
Thanks @mitshell I've tested and confirmed that the fix works. Much appreciated.
Hi @mitshell Would it be possible to get a new release? Thanks.
The issue may be reproduced by using the following pytest.