search

pycroscopy / SciFiReaders

Tools for extracting data and metadata from scientific data files
https://pycroscopy.github.io/SciFiReaders/about.html
MIT License
13 stars 13 forks source link

fix: update from igor to igor2 #97

Closed nsulmol closed 1 year ago

nsulmol commented 1 year ago

igor no longer works with numpy as of numpy 1.20. If trying to import SciFiReaders with igor, we get the following error:

"AttributeError: module 'numpy' has no attribute 'complex'."

indicating the issue. Because of this deprecation issue, AFM-Analysis have forked the original wking/igor, and updated it into a new repository called igor2.

This CL updates SciFiReaders to use igor2 instead of igor. The igor unit tests have been tested and pass. The changes here correspond exclusively to changing text from 'igor' to 'igor2' for package purposes and user prompts (we do not change any class/variable names).

Note: for 2 files, the diff will show the addition of a \newline at the end of the file. This is unix policy and done by default by my editor.

resolves #96

ramav87 commented 1 year ago

Thanks! I believe this also means there will be version incompatibility with python 3.7 since igor2 requires 3.8 or above. I will go ahead and merge this now and then we will remove 3.7 compatibility for SciFiReaders soon.

ramav87 commented 1 year ago

@gduscher we will need to remove python 3.7 compatibility. Something more to discuss.

nsulmol commented 1 year ago

Thanks! I believe this also means there will be version incompatibility with python 3.7 since igor2 requires 3.8 or above. I will go ahead and merge this now and then we will remove 3.7 compatibility for SciFiReaders soon.

Yes, your test suite caught that (it was not something I had considered, excuse me). The igor2 pyproject.toml explicits that it needs 3.8+. Thank you for pulling it in.

rajgiriUW commented 1 year ago

Wonderful!