search

pycroscopy / sidpy

Python utilities for storing, processing, and visualizing spectroscopic and imaging data
https://pycroscopy.github.io/sidpy/
MIT License
11 stars 14 forks source link

Dev gerd 04 #120

Closed gduscher closed 3 years ago

ramav87 commented 3 years ago

@gduscher Gerd, I think this was my fault because the test I wrote was failing. It's updated now and merged into master without issue. I wonder if I can accept the pull request and it will work, or if it needs to be resubmitted?

gduscher commented 3 years ago

Hi Rama, Will do, Gerd

From: ramav87 @.> Sent: Tuesday, May 11, 2021 12:21 PM To: pycroscopy/sidpy @.> Cc: Duscher, Gerd J @.>; Mention @.> Subject: Re: [pycroscopy/sidpy] Dev gerd 04 (#120)

@gduscherhttps://github.com/gduscher Gerd, I think this was my fault because the test I wrote was failing. It's updated now and merged into master without issue. Can you pull from master and then resubmit the pull request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/pycroscopy/sidpy/pull/120#issuecomment-838776004, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL53B4GXI2LDP67TR5LZQNTTNFKNVANCNFSM44LW7ESQ.

gduscher commented 3 years ago

Hi Rama, I just merged my pull.

There was no conflict with master so there was no problem merging it, once your test was fixed.

Gerd From: ramav87 @.> Sent: Tuesday, May 11, 2021 12:21 PM To: pycroscopy/sidpy @.> Cc: Duscher, Gerd J @.>; Mention @.> Subject: Re: [pycroscopy/sidpy] Dev gerd 04 (#120)

@gduscherhttps://github.com/gduscher Gerd, I think this was my fault because the test I wrote was failing. It's updated now and merged into master without issue. Can you pull from master and then resubmit the pull request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/pycroscopy/sidpy/pull/120#issuecomment-838776004, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL53B4GXI2LDP67TR5LZQNTTNFKNVANCNFSM44LW7ESQ.

ramav87 commented 3 years ago

Thanks Gerd!

Rama

On Tue, May 11, 2021, 1:20 PM Gerd Duscher @.***> wrote:

Hi Rama, I just merged my pull.

There was no conflict with master so there was no problem merging it, once your test was fixed.

Gerd From: ramav87 @.> Sent: Tuesday, May 11, 2021 12:21 PM To: pycroscopy/sidpy @.> Cc: Duscher, Gerd J @.>; Mention @.> Subject: Re: [pycroscopy/sidpy] Dev gerd 04 (#120)

@gduscherhttps://github.com/gduscher Gerd, I think this was my fault because the test I wrote was failing. It's updated now and merged into master without issue. Can you pull from master and then resubmit the pull request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub< https://github.com/pycroscopy/sidpy/pull/120#issuecomment-838776004>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AL53B4GXI2LDP67TR5LZQNTTNFKNVANCNFSM44LW7ESQ>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pycroscopy/sidpy/pull/120#issuecomment-838858526, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNDQFIR7RQ4PHATQJ4ELOTTNFRMPANCNFSM44LW7ESQ .