search

pycroscopy / sidpy

Python utilities for storing, processing, and visualizing spectroscopic and imaging data
https://pycroscopy.github.io/sidpy/
MIT License
11 stars 14 forks source link

plot_scree for h5py>=3 #122

Closed rajgiriUW closed 3 years ago

rajgiriUW commented 3 years ago

Addresses Issue #105 which is part of a slightly larger issue (potentially) of h5py >=3 being more strict in handling Datasets, I think.

Wasn't sure of the best way to write the test, since I just want to see if it passes when using an h5py Dataset.

codecov-commenter commented 3 years ago

Codecov Report

Merging #122 (edc4ee2) into master (a2dc6b1) will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   75.31%   75.49%   +0.18%     
==========================================
  Files          44       44              
  Lines        7535     7542       +7     
==========================================
+ Hits         5675     5694      +19     
+ Misses       1860     1848      -12
Flag Coverage Δ
unittests 75.49% <100.00%> (+0.18%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sidpy/viz/plot_utils/curve.py 24.37% <100.00%> (+4.87%) :arrow_up:
tests/viz/test_plot_utils.py 99.46% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2dc6b1...edc4ee2. Read the comment docs.