search

pycroscopy / sidpy

Python utilities for storing, processing, and visualizing spectroscopic and imaging data
https://pycroscopy.github.io/sidpy/
MIT License
11 stars 14 forks source link

Fix for NaN values in plot_map and in get_exponent #125

Closed rajgiriUW closed 3 years ago

rajgiriUW commented 3 years ago

For issue #124 . Get_exponent returns TypeError now with informative error message if vector contains nan values. Plot_map ignores nan values when calling get_exponent. Tests added for both

codecov-commenter commented 3 years ago

Codecov Report

Merging #125 (19a8593) into master (f5ad361) will increase coverage by 0.97%. The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   75.49%   76.47%   +0.97%     
==========================================
  Files          44       44              
  Lines        7542     7561      +19     
==========================================
+ Hits         5694     5782      +88     
+ Misses       1848     1779      -69
Flag Coverage Δ
unittests 76.47% <86.66%> (+0.97%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/base/test_num_utils.py 93.10% <0.00%> (-0.81%) :arrow_down:
sidpy/base/num_utils.py 96.29% <50.00%> (-1.18%) :arrow_down:
sidpy/viz/plot_utils/image.py 40.00% <100.00%> (+31.37%) :arrow_up:
tests/viz/test_plot_utils.py 99.50% <100.00%> (+0.03%) :arrow_up:
sidpy/viz/plot_utils/misc.py 26.57% <0.00%> (+7.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5ad361...19a8593. Read the comment docs.