search

pydanny / cookiecutter-djangopackage

A cookiecutter template for creating reusable Django packages quickly.
436 stars 153 forks source link

Add Django 3.X, Py3.7-8; Drop Dj1.11, Py2 #967

Open Andrew-Chen-Wang opened 3 years ago

Andrew-Chen-Wang commented 3 years ago

Python 2.7 is coming to the end of its lifetime, and many packages like Django are following along. In this PR, I've also added Django 3.0 and Django 3.1 with Python 3.7 and Python 3.8.

jonathan-s commented 3 years ago

Hey @Andrew-Chen-Wang, I completely missed this PR. If you fix the tests for this one I think I'll be able to get this merged in.

Andrew-Chen-Wang commented 3 years ago

Ah apologies, it's been awhile (and tbh I forgot) since I've started this PR. Some flake8 issue:

EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')

I'll check to make sure that the lint won't fail on Python 3.7 soon.

jonathan-s commented 3 years ago

Thanks!

Andrew-Chen-Wang commented 3 years ago

Hey @jonathan-s I'm not able to properly read what flake8 is actually... saying? The only things I can tell is that pytest is spewing runtests.py and tasks.py as errored files, but I didn't even update them...? I've updated this to drop Python 3.5 and add Python 3.9 though.

paiuolo commented 3 years ago

Any news?