Feature/mark custom types

pydantic / bump-pydantic

Convert Pydantic from V1 to V2 ♻

MIT License

317 stars 24 forks source link

Feature/mark custom types #116

Closed JensHeinrich closed 1 year ago

JensHeinrich commented 1 year ago

EDIT by @Kludex:

Closes #106

JensHeinrich commented 1 year ago

[x] Rebase and reorder to make the "Fixes" commit the last commit after fixing the feature

slafs commented 1 year ago

Nice! Thank you. This will be useful for us too! 🙇 (haven't reviewed this PR though)

Just noticed that the rule code should probably be BP009 (or BP011 maybe). The last current working one is BP008, but BP009 and BP010 are only mentioned in the README, they are not-implemented and commented out in the README. Looks like the last time a new mod was added (BP008), Marcelo incremented the number of commented out mods and used first "free" one. See #90.

JensHeinrich commented 1 year ago

Nice! Thank you. This will be useful for us too! 🙇 (haven't reviewed this PR though)

Just noticed that the rule code should probably be BP009 (or BP011 maybe). The last current working one is BP008, but BP009 and BP010 are only mentioned in the README, they are not-implemented and commented out in the README. Looks like the last time a new mod was added (BP008), Marcelo incremented the number of commented out mods and used first "free" one. See #90.

Ok, thought I would just append to the commented one^^

JensHeinrich commented 1 year ago

Nice! Thank you. This will be useful for us too! 🙇 (haven't reviewed this PR though)

Just noticed that the rule code should probably be BP009 (or BP011 maybe). The last current working one is BP008, but BP009 and BP010 are only mentioned in the README, they are not-implemented and commented out in the README. Looks like the last time a new mod was added (BP008), Marcelo incremented the number of commented out mods and used first "free" one. See #90.

Updated the numbering