Closed davidhewitt closed 1 week ago
Attention: Patch coverage is 95.18072%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 94.01%. Comparing base (
dd25fd0
) to head (08b4cd3
).
Files with missing lines | Patch % | Lines |
---|---|---|
crates/jiter/src/value.rs | 95.18% | 8 Missing :warning: |
Comparing dh/iterative-take
(546c4df) with main
(dd25fd0)
⚡ 1
improvements
❌ 1
regressions
✅ 71
untouched benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmark | main |
dh/iterative-take |
Change | |
---|---|---|---|---|
⚡ | pass2_jiter_value |
22.1 µs | 17.1 µs | +29.51% |
❌ | x100_jiter_skip |
1.2 µs | 1.3 µs | -10.97% |
The slowdown is probably an inlining loss in unrelated code which can be recovered by PGO. The +24% seems very real.
Similar to #111, but for real work in
take_value
. If this adds a perf boost I can apply the same design to the Python functions too...