Closed samuelcolvin closed 3 months ago
Comparing check-duplicate-keys
(c350499) with main
(75699eb)
❌ 1
regressions
✅ 72
untouched benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmark | main |
check-duplicate-keys |
Change | |
---|---|---|---|---|
❌ | pass2_jiter_skip |
5.5 µs | 7 µs | -21.04% |
All modified and coverable lines are covered by tests :white_check_mark:
:loudspeaker: Thoughts on this report? Let us know!
Bench change doesn't look significant, maybe an inlining change in Rust 1.78. I think the skip
functions can probably avoid recursion so I'll try to transform them next week and optimise them that way 😄
Optionally check for duplicate keys in
python_parse
.