Closed alexmojaki closed 2 weeks ago
A lot of long text about use cases that may put off users
Agree. We should reduce it.
TODOs where screenshots should be
Yes. We should AT least remove the TODOs.
Poor use of f-strings, e.g. logfire.span(f"Performing search: {search_query}", search_query=search_query, ...). This was written before f-string magic, but it doesn't make sense with or without.
We should just fix it - I don't care if we use the f-string or not, but the current one just doesn't make sense, as you mentioned.
Here is a proposed new outline for the page:
I agree with the outline.
https://docs.pydantic.dev/logfire/guides/onboarding_checklist/add_manual_tracing/ currently has several issues as discussed with @Kludex and @dmontagu, including:
logfire.span(f"Performing search: {search_query}", search_query=search_query, ...)
. This was written before f-string magic, but it doesn't make sense with or without.Here is a proposed new outline for the page:
with logfire.span('This is a span'): logfire.info('This is an info log'); time.sleep(1)
end_timestamp - start_timestamp > interval '1 second'
in live view.records
table with the same columns.log.info('Hello', name='world')
attributes->>'name' = 'world'
span.set_attribute
logfire.info
etc. have other keyword arguments starting with underscore. These are not private and users can use them. Attributes cannot start with underscore to keep the namespace reserved.for name in ['Alice', 'Bob', 'Charlie']: log.info('Hello {name}', name=name)
span_name = 'Hello {name}'
vsmessage like 'Hello %'
_span_name
kwargspan.message
writeable property@logfire.instrument
logfire.exception
_exc_info
kwargspan.record_exception
logfire.info/error
etc vslogfire.log
info
by defaultlevel > level_num('info')
span.set_level