pydantic / logfire

Uncomplicated Observability for Python and beyond! 🪵🔥
https://docs.pydantic.dev/logfire/
MIT License
1.62k stars 46 forks source link

Restructure manual tracing docs #229

Closed alexmojaki closed 2 weeks ago

alexmojaki commented 3 weeks ago

https://docs.pydantic.dev/logfire/guides/onboarding_checklist/add_manual_tracing/ currently has several issues as discussed with @Kludex and @dmontagu, including:

Here is a proposed new outline for the page:

Kludex commented 3 weeks ago

A lot of long text about use cases that may put off users

Agree. We should reduce it.

TODOs where screenshots should be

Yes. We should AT least remove the TODOs.

Poor use of f-strings, e.g. logfire.span(f"Performing search: {search_query}", search_query=search_query, ...). This was written before f-string magic, but it doesn't make sense with or without.

We should just fix it - I don't care if we use the f-string or not, but the current one just doesn't make sense, as you mentioned.

Here is a proposed new outline for the page:

I agree with the outline.