pydantic / logfire

Uncomplicated Observability for Python and beyond! 🪵🔥
https://docs.pydantic.dev/logfire/
MIT License
1.62k stars 46 forks source link

Keep the default span processor when `processors` is passed to `logfire.configure()` #233

Closed alexmojaki closed 3 weeks ago

alexmojaki commented 3 weeks ago

Closes https://github.com/pydantic/logfire/issues/99

This is a breaking change, but since we'll probably do this eventually anyway it's best to do it now. I can't see a reason for the current behaviour.

adriangb commented 3 weeks ago

I assume if you want to get rid of the default processor you're supposed to pass send_to_logfire=False?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

alexmojaki commented 3 weeks ago

Yes

cloudflare-pages[bot] commented 3 weeks ago

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fffa63
Status: âœ…  Deploy successful!
Preview URL: https://76e30c55.logfire-docs.pages.dev
Branch Preview URL: https://alex-processors.logfire-docs.pages.dev

View logs

alexmojaki commented 3 weeks ago

OK I've renamed, and processors will now raise an error telling you to use additional_span_processors.

adriangb commented 3 weeks ago

Looks great!