pydantic / logfire

Uncomplicated Observability for Python and beyond! 🪵🔥
https://docs.pydantic.dev/logfire/
MIT License
1.62k stars 46 forks source link

[PYD-617] Remove default for modules parameter of `install_auto_tracing` #261

Closed alexmojaki closed 2 weeks ago

alexmojaki commented 2 weeks ago

Currently by default:

This means that providing no arguments will always raise an error about wanting to trace the current module which has obviously already been imported. Either modules or check_imported_modules must be specified. This is a bit weird.

This PR makes things less weird by requiring the user to specify modules. This seems like a case where explicit really is better than implicit.

linear[bot] commented 2 weeks ago

PYD-617 `install_auto_tracing()` without arguments is always an error

cloudflare-pages[bot] commented 2 weeks ago

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b85bd3
Status: âœ…  Deploy successful!
Preview URL: https://a9f85f4a.logfire-docs.pages.dev
Branch Preview URL: https://alex-no-default-auto-trace-m.logfire-docs.pages.dev

View logs

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!