search

pydantic / logfire

Uncomplicated Observability for Python and beyond! 🪵🔥
https://logfire.pydantic.dev/docs/
MIT License
2.17k stars 65 forks source link

Daily CI with unpinned deps #580

Open alexmojaki opened 1 day ago

alexmojaki commented 1 day ago

Following up on https://github.com/pydantic/logfire/pull/576

At the bare minimum we need a job that runs daily with the latest versions of all dependencies so that we can detect breakages.

Previously regular CI ran with unpinned dependencies which forced us to fix the problem ASAP. That had downsides, but I want to keep the upsides. I want to have some kind of system so that when the job fails we treat it with similar urgency to before, so that new users aren't immediately faced with a critical error caused by an outstanding bug. Relevant developers should definitely get an email about the job failing, but that's not quite enough. I may miss the email in a sea of notifications, or I may think someone else will deal with it. For now let's just say that if any of us see that CI has failed we should open an urgent issue if there isn't one already, and check with the team what the plan is.

Kludex commented 1 day ago

We can also add a weekly dependabot job?

Kludex commented 1 day ago

Daily also works (the previous PR is closed).

alexmojaki commented 1 day ago

That also works, but I also want daily CI for other things like testing a wider variety of versions as in https://github.com/pydantic/logfire/issues/507 without slowing down PRs.

Kludex commented 1 day ago

I forgot that uv.lock doesn't seem supported by dependabot yet.

alexmojaki commented 12 hours ago

Reopening because based on https://github.com/orgs/community/discussions/25351 the current workflow will only send an email to a single person, which isn't loud enough.

alexmojaki commented 12 hours ago

(I know there's a TODO in that file in the PR which is probably because of this, I hadn't noticed until merging)