Lower MSRV to 1.75 - Githubissues

pydantic / pydantic-core

Core validation logic for pydantic written in rust

MIT License

1.4k stars 232 forks source link

Lower MSRV to 1.75 #1316

Closed tiran closed 4 months ago

tiran commented 4 months ago

Change Summary

Lower MSRV to 1.75. Rust 1.75 is the lowest working Rust version.

Related issue number

fix: #1315

Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

tiran commented 4 months ago

please review

MSRV is not mentioned in README.md and there are no tests beyond the "test MSRV" job. Lowering MSRV should not have an impact on pydantic tests, either.

codspeed-hq[bot] commented 4 months ago

CodSpeed Performance Report

Merging #1316 will not alter performance

_{Comparing tiran:lower-msrv (9f2014d) with main (77f2b69)}

Summary

✅ 155 untouched benchmarks