Closed uriyyo closed 1 week ago
please review
Comparing uriyyo:list-fail-fast
(27db075) with main
(9507a28)
✅ 155
untouched benchmarks
Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review. |
Files | Patch % | Lines |
---|---|---|---|
src/validators/tuple.rs | 86.36% | 3 Missing :warning: |
:loudspeaker: Thoughts on this report? Let us know!
Great, I will update this PR to add this feature to more iterable types!
Could we implement this as an exception, similar to PydanticOmit
? That way a python-defined validator can control the flow.
@adriangb Makes sense to me, I will try to reimplement it in similar way as PydanticOmit
is working
It may be that both are necessary, there's mutliple use cases:
Hi @adriangb @davidhewitt
This PR is ready with basic implementation of fail-fast feature for list, set, frozenset, and tuple types.
Could we implement this as an exception, similar to PydanticOmit? That way a python-defined validator can control the flow.
@adriangb I suggest implement this feature in separate PR just to make review/merge process easier. What do you think about it?
Makes sense to me
I see the Python PR is now prepared too, many thanks 🚀
Change Summary
Add list fail-fast config option.
Related issue number
fix: #1321
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @dmontagu