use full type names in errors

pydantic / pydantic-core

Core validation logic for pydantic written in rust

MIT License

1.4k stars 232 forks source link

use full type names in errors #1342

Closed davidhewitt closed 3 months ago

davidhewitt commented 3 months ago

Change Summary

Supersedes #1276, using a new PyO3 0.22 API to get the full type name.

Related issue number

Closes https://github.com/pydantic/pydantic/issues/7911

Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

sydney-runkle commented 3 months ago

I'm ok with this, but this is potentially a breaking change for some folks, so let's wait until the next minor release (tomorrow or Wednesday probably), so that we can chat about this before merging.

sydney-runkle commented 3 months ago

I'm guessing it would generally only break tests, but still...

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #1342 will not alter performance

_{Comparing dh/full-type-names (9abbdfa) with main (7b62646)}

Summary

✅ 155 untouched benchmarks

samuelcolvin commented 3 months ago

Personally I'm :-1: for this, I think it'll be a significant breaking change for lots of people because of tests, I also think it's a bit uglier for little gain.

sydney-runkle commented 3 months ago

Closing for now, given the above comment