Closed josh-newman closed 1 month ago
please review
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.61%. Comparing base (
ab503cb
) to head (f7170c5
). Report is 139 commits behind head on main.
Comparing d8e-ai:validate-base64-any
(f7170c5) with main
(6e96b85)
✅ 155
untouched benchmarks
Change Summary
Extends bytes base64 validation to accept standard encoding, in addition to the existing URL-safe.
I think a user providing base64 standard input is more likely to want successful (and unambiguous) decoding rather than a validation error. (Even while
ser_json_bytes="base64"
continues to emit the URL-safe variant.)Related issue number
No issue, but this extends #1308: https://github.com/pydantic/pydantic-core/pull/1308#issuecomment-2143130478
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @dmontagu