search

pydantic / pydantic-extra-types

Extra Pydantic types.
MIT License
181 stars 48 forks source link

Add Pendulum DT support #110

Closed theunkn0wn1 closed 7 months ago

theunkn0wn1 commented 9 months ago

Adds a proxy type for pendulum.DateTime, allowing pendulum DTs to be used in Pydantic base models.

closes pydantic/pydantic-extra-types#112

depends on #111

theunkn0wn1 commented 9 months ago

Tests are failing due to deprecation warnings being thrown in tests out of scope of this PR. The Lint task is failing due to some seemingly out of scope error in MyPy. Do I need to fix these?

hramezani commented 9 months ago

Just merged https://github.com/pydantic/pydantic-extra-types/pull/113 The CI problem will probably be fixed by rebasing on top of the main.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (634487f) 100.00% compared to head (1bf0d91) 100.00%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 11 +1 Lines 665 685 +20 Branches 166 169 +3 ========================================= + Hits 665 685 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

theunkn0wn1 commented 9 months ago

Converted to draft as #111 needs to merge first.

Apilny commented 8 months ago

It looks like the blocking PR has been merged, will this feature be implemented in the near future? My team and I would appreciate support for Pendulum DT, thanks!

theunkn0wn1 commented 8 months ago

PR rebased and made ready for review.

Apilny commented 7 months ago

Hey there, just wanted to bump this pr, would love the support, thanks!

theunkn0wn1 commented 7 months ago

@sydney-runkle and/or @yezz123 can I get a review on this PR please?

(tagged since you previously merged PRs in this repo and/or self-assigned themself to this PR)