search

pydantic / pydantic-extra-types

Extra Pydantic types.
MIT License
181 stars 48 forks source link

:memo: Refactor Documentation for ISBN and MAC address modules #124

Closed yezz123 closed 7 months ago

yezz123 commented 8 months ago

I try it locally its working fine

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d05c882) 100.00% compared to head (5caa73e) 100.00%. Report is 10 commits behind head on main.

:exclamation: Current head 5caa73e differs from pull request most recent head 2838771. Consider uploading reports for the commit 2838771 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 665 665 Branches 166 166 ========================================= Hits 665 665 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sydney-runkle commented 8 months ago

I try it locally its working fine

Does this mean that you've tried serving the pydantic docs locally with these changes, and things run as expected?

sydney-runkle commented 8 months ago

@yezz123,

Any chance you'll be able to incorporate some changes soon? Hoping to release a new version of pydantic and would love to get this new version of pydantic-extra-types in.

yezz123 commented 8 months ago

@sydney-runkle we are ready to go!

sydney-runkle commented 8 months ago

@yezz123,

Thanks for your work on this docs refactor. I'd like to provide some more feedback on some of the changes, and a lot of them aren't relevant to fixing the docs build issue we ran into with 2.4.0. I've opened a PR here to fix those issues, then I'll address these changes early next week! https://github.com/pydantic/pydantic-extra-types/pull/125