search

pydantic / pydantic-extra-types

Extra Pydantic types.
MIT License
181 stars 48 forks source link

Do not pin the ”major” version of pycountry #132

Closed musicinmybrain closed 7 months ago

musicinmybrain commented 7 months ago

Since pycountry uses a calendar-based versioning scheme, this doesn’t have the effect it would for a SemVer dependency. Breaking changes are not more likely to happen at the beginning of a calendar year than in the middle of one, and pinning the version is likely to cause more headaches than it prevents.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2b0e028) 100.00% compared to head (00568d4) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 11 Lines 685 685 Branches 169 169 ========================================= Hits 685 685 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Kludex commented 7 months ago

Thanks @musicinmybrain 🙏