pydantic / pydantic-extra-types

Extra Pydantic types.

MIT License

176 stars 47 forks source link

DSN migration for pydantic v3 #172

Open CherrySuryp opened 3 months ago

CherrySuryp commented 3 months ago

This PR is related to this task from Pydantic main library. I moved DSN types and tests from original pydantic/networks.py without any changes

Checklist

✅ The pull request title is a good summary of the changes - it will be used in the changelog ✅ Unit tests for the changes exist

Selected Reviewer: @yezz123

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

CherrySuryp commented 3 months ago

Please review

CherrySuryp commented 3 months ago

Hello there! All checks for Python 3.8 have failed :( It fell with error: ImportError: cannot import name 'Annotated' from 'typing' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/typing.py).

Seems like Python 3.8 doesn't have Annotated class

CherrySuryp commented 3 months ago

I also think it would make sense to move the entire pydantic/networks.py module to pydantic-extra-types

CherrySuryp commented 3 months ago

@yezz123 @sydney-runkle can we move other stuff from pydantic/networks.py to current libraray? I can do it in this PR