Closed jbkroner closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
e186814
) to head (563284f
). Report is 38 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
please review
@yezz123 fixes applied. apologies for the extra commits - didn't click that I could run the linter / pre-commit stuff locally (duh) following the instructions in the main pydantic repo.
@yezz123 fixes applied. apologies for the extra commits - didn't click that I could run the linter / pre-commit stuff locally (duh) following the instructions in the main pydantic repo.
No Problem now we have it ready we can merge it, Thanks for the great work @jbkroner 🚀
Adding a semantic version type as requested in #2506 in the pydantic repo.
The implementation here is just the example from the python-semver docs + some additional tests.
When this PR gets a thumbs up I will update the docs in python-semver.
Any feedback appreciated, cheers.
edit: tracking on coverage and 3.8 compatibility issues, will try to get that covered early this week before marking as ready for review.
Selected Reviewer: @yezz123