pydantic / pydantic-extra-types

Extra Pydantic types.
MIT License
193 stars 51 forks source link

✨ add `ULID` type #73

Closed JeanArhancet closed 1 year ago

JeanArhancet commented 1 year ago

Resolves #67

Selected Reviewer: @Kludex

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8e9b1e8) 100.00% compared to head (179393b) 100.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #73 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 9 +1 Lines 599 637 +38 Branches 152 158 +6 ========================================= + Hits 599 637 +38 ``` | [Files](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic) | Coverage Δ | | |---|---|---| | [pydantic\_extra\_types/coordinate.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvY29vcmRpbmF0ZS5weQ==) | `100.00% <100.00%> (ø)` | | | [pydantic\_extra\_types/country.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvY291bnRyeS5weQ==) | `100.00% <ø> (ø)` | | | [pydantic\_extra\_types/mac\_address.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvbWFjX2FkZHJlc3MucHk=) | `100.00% <100.00%> (ø)` | | | [pydantic\_extra\_types/payment.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvcGF5bWVudC5weQ==) | `100.00% <100.00%> (ø)` | | | [pydantic\_extra\_types/phone\_numbers.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvcGhvbmVfbnVtYmVycy5weQ==) | `100.00% <100.00%> (ø)` | | | [pydantic\_extra\_types/routing\_number.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvcm91dGluZ19udW1iZXIucHk=) | `100.00% <100.00%> (ø)` | | | [pydantic\_extra\_types/ulid.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvdWxpZC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JeanArhancet commented 1 year ago

please review

andygarfield commented 1 year ago

@JeanArhancet There's a typo in the title, which probably shouldn't make into the changelog. Also, maybe this hasn't been reviewed because it's a draft?

JeanArhancet commented 1 year ago

Thank you for your feedback @andygarfield

I removed the _init_..etc in the last commit to use pydantic v2 functions. The PR is ready @Kludex

Colk-tech commented 1 year ago

Why isn't this PR merged? I really wawnt this feature so, if there are any left work to do, I will work on them. Tell me what is needed to get this PR merged.