search

pydantic / pydantic-extra-types

Extra Pydantic types.
MIT License
181 stars 48 forks source link

Fix mac adddress validation #79

Closed JeanArhancet closed 1 year ago

JeanArhancet commented 1 year ago

There's a MAC address validation issue here PR

This PR deletes the __init__ function and uses the pydantic functions to return a MAC address in the correct format.

Selected Reviewer: @Kludex

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (70681b9) 100.00% compared to head (b8c6fdc) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 538 541 +3 Branches 138 138 ========================================= + Hits 538 541 +3 ``` | [Impacted Files](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic) | Coverage Δ | | |---|---|---| | [pydantic\_extra\_types/mac\_address.py](https://app.codecov.io/gh/pydantic/pydantic-extra-types/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-cHlkYW50aWNfZXh0cmFfdHlwZXMvbWFjX2FkZHJlc3MucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

JeanArhancet commented 1 year ago

please review