search

pydantic / pydantic-settings

Settings management using pydantic
https://docs.pydantic.dev/latest/usage/pydantic_settings/
MIT License
593 stars 61 forks source link

Replace tomlkit with tomli and remove toml_file_encoding config #236

Closed hramezani closed 7 months ago

hramezani commented 7 months ago

Fixes https://github.com/pydantic/pydantic-settings/issues/235

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (965d1b4) 97.63% compared to head (a1e7f82) 97.14%.

Files Patch % Lines
pydantic_settings/sources.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== - Coverage 97.63% 97.14% -0.49% ========================================== Files 5 5 Lines 422 420 -2 Branches 89 89 ========================================== - Hits 412 408 -4 - Misses 7 9 +2 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hramezani commented 7 months ago

LGTM, only question is whether we should fall back to tomlkit if tomli is not installed?

I think we don't need to fall back on tomlkit