search

pydantic / speedate

Fast and simple datetime, date, time and duration parsing for rust.
https://docs.rs/speedate/latest/speedate/
MIT License
199 stars 17 forks source link

Fix Duration parsing #35

Closed aminalaee closed 1 year ago

aminalaee commented 1 year ago

Fixes https://github.com/pydantic/speedate/issues/34

lig commented 1 year ago

@samuelcolvin this blocks https://github.com/pydantic/speedate/issues/34 which we want for Pydantic V2 Beta 3 https://github.com/pydantic/pydantic/issues/6096

codecov-commenter commented 1 year ago

Codecov Report

Merging #35 (6dbfe4a) into main (aa33bd2) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 99.50% 99.51% +0.01% ========================================== Files 6 6 Lines 801 819 +18 ========================================== + Hits 797 815 +18 Misses 4 4 ``` | [Impacted Files](https://app.codecov.io/gh/pydantic/speedate/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic) | Coverage Δ | | |---|---|---| | [src/datetime.rs](https://app.codecov.io/gh/pydantic/speedate/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-c3JjL2RhdGV0aW1lLnJz) | `96.62% <ø> (ø)` | | | [src/duration.rs](https://app.codecov.io/gh/pydantic/speedate/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-c3JjL2R1cmF0aW9uLnJz) | `100.00% <100.00%> (ø)` | | | [src/time.rs](https://app.codecov.io/gh/pydantic/speedate/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic#diff-c3JjL3RpbWUucnM=) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pydantic/speedate/pull/35?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pydantic/speedate/pull/35?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic). Last update [aa33bd2...6dbfe4a](https://app.codecov.io/gh/pydantic/speedate/pull/35?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydantic).
samuelcolvin commented 1 year ago

thanks so much.