Closed adriangb closed 1 year ago
please review
Merging #45 (96d31a1) into main (ed75c5b) will decrease coverage by
0.11%
. The diff coverage is93.93%
.
I think this should be unix_tz
a bool or enum with two options.
or enum with two options
It is an enum with two options
I think this should be
unix_tz
a bool or enum with two options.
Do you mean the name of the field on TimeConfig
? Or something else?
#[derive(Debug, Clone, Default, Copy)]
pub enum DefaultTimeOffset {
#[default]
Naive,
Utc,
}
// ...
#[derive(Debug, Clone, Default)]
pub struct TimeConfig {
pub microseconds_precision_overflow_behavior: MicrosecondsPrecisionOverflowBehavior,
pub default_time_offset: DefaultTimeOffset,
}
Are you just suggesting changing default_time_offset
to unix_tz
?
If the input is a number or a numeric string both of which are interpreted as Unix timestamps, then this setting should decide if the timezone is None
or Some(0)
.
Hence the struct member name should change to unix_tz
.
please review
Fix #41.