search

pydantic / speedate

Fast and simple datetime, date, time and duration parsing for rust.
https://docs.rs/speedate/latest/speedate/
MIT License
199 stars 17 forks source link

Support time duration more than 23 #64

Closed nix010 closed 3 months ago

nix010 commented 4 months ago

Fix #63 . support for https://github.com/pydantic/pydantic/issues/8673

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review. Files Patch % Lines
src/duration.rs 92.68% 3 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

nix010 commented 3 months ago

@davidhewitt btw, the lint job failed with the README file so how should I resolve it ?

error: needless `fn main` in doctest
  --> src/../README.md:43:1
davidhewitt commented 3 months ago

Just remove the fn main() { and de-indent the contents from the offending snippets.

e.g.

fn main() {
    foo
}

becomes 

foo
nix010 commented 3 months ago

@davidhewitt Thank you! all work now. I'm learning rust by doing these PRs and gain a lot of your suggesions. Cheers.