search

pydata / bottleneck

Fast NumPy array functions written in C
BSD 2-Clause "Simplified" License
1.07k stars 104 forks source link

Can built package drop versioneer dependency? #451

Closed ctwardy closed 5 months ago

ctwardy commented 5 months ago

Note: I had a pandas[performance] install fail because bottleneck depends on versioneer which wasn't in my company's repository.

Not sure how it works, but intuitively versioneer seems a dev dependency.

Seems bottleneck uses "non-vendored" mode, which makes versioneer a build-system requirement. Wondering if "vendored" mode would solve that. Even if it does, it might not be worth it as versioneer looks bland enough to get into company repos.

Just hadn't ever hit this issue before installing other packages, and it seemed odd .

rdbisme commented 5 months ago

Mmmh, are you sure? versioneer is a build dependency, not even a development dependency, and it's not listed in the setup.py. My guess is that your company registry didn't have a pre-built wheel of bottleneck, which triggered a full local rebuild, which requires versioneer?

ctwardy commented 5 months ago

Ah, that makes sense – getting a wheel for bottleneck might solve it. I’ll close the ticket.