search

pydata / numexpr

Fast numerical array expression evaluator for Python, NumPy, Pandas, PyTables and more
https://numexpr.readthedocs.io/en/latest/user_guide.html
MIT License
2.23k stars 210 forks source link

MNT: use compat functions for accessing dtype state #475

Closed tacaswell closed 7 months ago

tacaswell commented 8 months ago

This complies with the numpy main branch, but did not test with older versions of numpy (I suspect it wont work due to missing functions)

The np_2_compat.h is designed to be vendored down stream, I think the question is if numexpr wants the whole thing or just the minimal sub-set needed to fix these problems.

FrancescAlted commented 8 months ago

Ok, your PR does not compile yet. I think there should be no problem in vendoring np_2_compat.h, but at any rate, you could start by adding it here and decide later. Thanks!

FrancescAlted commented 7 months ago

Overridden by https://github.com/pydata/numexpr/pull/478

tacaswell commented 7 months ago

🎉 Thank you! I did not have time to come back and finish this and it looks like @neutrinoceros did a better job than I would have anyway!

neutrinoceros commented 7 months ago

Oh my, I absolutely didn't realize I was scoping your PR, sorry I didn't look hard enough !