search

pydata / patsy

Describing statistical models in Python using symbolic formulas
Other
955 stars 104 forks source link

MAINT: Repalce row_stack with vstack #202

Closed bashtage closed 11 months ago

bashtage commented 11 months ago

row_stack is official deprecated in NumPy 2, and will be dropped eventually. Currently produces a warning

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ae3e8cb) 98.37% compared to head (f3db6cc) 98.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #202 +/- ## ======================================= Coverage 98.37% 98.37% ======================================= Files 30 30 Lines 3140 3140 Branches 695 695 ======================================= Hits 3089 3089 Misses 26 26 Partials 25 25 ``` | [Flag](https://app.codecov.io/gh/pydata/patsy/pull/202/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydata) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pydata/patsy/pull/202/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydata) | `97.96% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pydata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matthewwardrop commented 11 months ago

LGTM. Thanks @bashtage .