pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
618 stars 321 forks source link

the RTD flyout create y-scrolling in the primary sidebar #1065

Closed 12rambau closed 1 year ago

12rambau commented 1 year ago

When the RTD flyout is captured by the primary sidebar there is an extra y-scrolling that appears on the right even thought the content of the sidebar itself is not requiring one.

Capture d’écran 2022-11-17 à 05 28 45
choldgraf commented 1 year ago

Here's one suggestion to fix this:

Make the RTD flyout a position: fixed container, so that it is always on the bottom of the screen, and no longer flows with the content in the sidebar. This would make it permanently visible, and would also avoid awkward problems with the "announcement banner" causing the sidebar to be hidden.

A few considerations:

@12rambau do you think it's important that we get this resolved before the next release?

choldgraf commented 1 year ago

I intend on removing this from the 0.13 milestone in the next day or so, so that it doesn't block a release, unless somebody asks me to hold off.

12rambau commented 1 year ago

We'd need to shrink the footer so that it only filled the space of the article content, rather than the whole screen.

I'm -1 on this. At some point we wanted to get closer to ng-sphinx and it's not respecting the template you send once: sphinx-ng-template

I think it make perfect sense for themes like jupyter books but here the sidebars are on & off it will be confusable with the footer-article

choldgraf commented 1 year ago

Yeah I agree with your analysis as well. The only problem is that I have no idea how we can solve this in any other way :-)

12rambau commented 1 year ago

I recently changed computer and I'm not seeing this issue anymore on v0.13.0 nor v0.12.0. Is it still the case for you ?

12rambau commented 1 year ago

My guess is that it disapeared as a side effect of one of our layout PR. Closing for now, if anyone sees it again don't hesitate to reopen or comment this issue