pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
613 stars 317 forks source link

There is always a scrollbar shown in the primary sidebar #1238

Open FranzRoters opened 1 year ago

FranzRoters commented 1 year ago

No matter how short the primary sidebar content is, I always get a scrollbar, even though it seems to be set to auto, as far as I understand the css code. Tested with 0.13.0 and 0.12.0.

vkbo commented 1 year ago

I've noticed this as well. For me, it only shows up in Chrome, but looks fine in Firefox. It seems to me to be caused by the sidebar end section, because this custom css fixes it for me (I have no content in that section).

.sidebar-primary-items__end {
    margin-bottom: 0 !important;
    margin-top: 0 !important;
}
FranzRoters commented 1 year ago

I get that behaviour in both Firefox and Edge on Windows.

The custom.css works for me with 0.13.0. Thanks vkbo. I did not think about the sidebar end section as it is empty for me as well.

12rambau commented 1 year ago

is it a "y" scrollbar or a "x" scrollbar ?

vkbo commented 1 year ago

It's vertical. At least it was in my case. Seemingly caused by the top and bottom margins of the __end box.

FranzRoters commented 1 year ago

I was also referring to a y-scrollbar (vertical).

12rambau commented 1 year ago

ok perfect because we had another "x" scrollbar issue and I was sure it was solved with 0.13

cbrnr commented 1 year ago

I have the same issue with Chrome and Safari (on macOS). Chrome renders a vertical sidebar, whereas Safari renders both vertical and horizontal scrollbars, even though the content easily fits into the available space. If it helps, I can post screenshots and/or margins/paddings for both browsers.

cbrnr commented 1 year ago

Safari (showing mne.tools):

https://github.com/pydata/pydata-sphinx-theme/assets/4377312/747ed4ce-18d0-4f01-b295-2fc4a9e2f233

Chrome looks the same, but only shows the vertical scrollbar.

12rambau commented 1 year ago

Could you try it again with the main branch, we actually removed the custom scrollbar which may have solve this issue as a side effect.

cbrnr commented 1 year ago

Nope, this didn't change anything: https://output.circle-artifacts.com/output/job/f85ea057-af56-418e-9d53-abd191e8c936/artifacts/0/html/index.html

ngulden commented 1 year ago

I use version 0.13.3 and have the same observation in Chrome and Brave. The workaround from https://github.com/pydata/pydata-sphinx-theme/issues/1238#issuecomment-1463465620 worked for me and the scrollbars disappear. Thanks.

Waiting for a new release so I can drop the workaround :wink:

adam-grant-hendry commented 1 year ago

Linking sphinx-book-theme #732 to this issue as sphinx-book-theme appears affected downstream by pydata-sphinx-theme.

adam-grant-hendry commented 1 year ago

I still experience this issue on sphinx-book-theme==1.0.1.

adam-grant-hendry commented 1 year ago

#1238 (comment) also worked for me (i.e. completely removed the scrollbar).

Follow-up: I don't mind the narrow scrollbar quite so much, but mine renders with an ugly large scrollbar like in sphinx-book-theme #732.

  1. Is anyone else suffering from this?
  2. Does anyone know how to make the scrollbar slim and dark until hovered like this?
jamesdbrock commented 2 months ago

I agree that https://github.com/pydata/pydata-sphinx-theme/issues/1238#issuecomment-1463465620 is a good workaround. The problem is here:

image

DocOtak commented 2 weeks ago

In my own investigation I found this is being caused by the negative margins on the rtd-footer-container as noted by https://github.com/pydata/pydata-sphinx-theme/issues/1794

It looks like this div added in relation to work going on in https://github.com/pydata/pydata-sphinx-theme/issues/705 but I myself cannot find an example of content being moved to that rtd footer container. It's possible RTD changed how it injects the flyout, but I did not investigate, I'm willing to take a crack at a PR if given some guidance on direction.

There are a few solutions I can think of, but I don't know the intended direction of the maintainers. My mental box-model is also not the best.