search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
618 stars 321 forks source link

Excess padding in nav bar dropdown #1421

Open gabalafou opened 1 year ago

gabalafou commented 1 year ago 
      .dropdown-menu {
        z-index: $zindex-popover;
        border: 1px solid var(--pst-color-border);
        box-shadow: 0 0 0.3rem 0.1rem var(--pst-color-shadow);
        background-color: var(--pst-color-on-background);
        padding: 0.5rem 0;

IMO we don't need the top/bottom padding either, but feel free to ignore this suggestion if you disagree

        padding: 0;

_Originally posted by @drammock in https://github.com/pydata/pydata-sphinx-theme/pull/1414#discussion_r1297758428_

gabalafou commented 5 months ago

If I understand correctly, this is what the before / after screenshots would look like (ignore the purple focus ring) after applying the change suggested here:

Before After
before padding after 0 padding
gabalafou commented 5 months ago

I think I prefer the before screenshot because the padding looks more equal. In fact, I might even increase the vertical padding some.

drammock commented 5 months ago

no strong feeling now that I've seen them side by side. Feel free to close if you like.

trallard commented 5 months ago

+1 on keeping the padding after seeing the comparison - think it would also be useful for anyone using touch devices